NO-JIRA: add a generator for plugins and reduce dependencies - #186
NO-JIRA: add a generator for plugins and reduce dependencies#186rikatz wants to merge 2 commits into
Conversation
This CoreDNS version is based on upstream, but relies just on a very small set of dependencies and plugins. This change adds a new generator for plugins, allowing a developer to re-generate the plugin list and dependencies based on OCP install and reducing the amount of imported libraries
openshift-ci-robot
added
the
jira/valid-reference
|
@rikatz: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedToo many files! This PR contains 296 files, which is 146 over the limit of 150. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (296)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@rikatz: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Some general comments:
|
openshift-ci
Bot
added
the
needs-rebase
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| go mod vendor | ||
| @echo "==> Done. Review changes with 'git diff --stat'" |
There was a problem hiding this comment.
During the rebase process, we run go mod vendor and commit the vendored files as a separate step — this is the "Vendor required modules" carry commit (coredns@358bd8f). So I would omit go mod vendor in generate-plugins and put this "reduce dependencies" commit before the "Vendor required modules" commit. The rebase process would be like this:
- Rebase on upstream.
- This step could pull in new plugins that need to be removed. That is, the list of plugins to remove can change during a rebase. However, the list of plugins to keep is static, with respect to a rebase.
- Start applying carry commits.
- When you reach the "reduce dependencies" commit, apply it, run
make generate-plugins, and commit the result. - Next, apply the "Vendor required modules" commit, run
go mod vendor, and commit the results. - Continue applying other carry commits.
There was a problem hiding this comment.
would someone be able to pick this work from here? I think it is important, but I wont be able to continue for the next cycle
4 participants
This CoreDNS version is based on upstream, but relies just on a very small set of
dependencies and plugins.
This change adds a new generator for plugins, allowing a developer to re-generate the
plugin list and dependencies based on OCP install and reducing the amount of imported
libraries